[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/adl: Display low battery message on screen

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Karthik Ramasubramanian has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email )

Change subject: soc/intel/adl: Display low battery message on screen
......................................................................

Patch Set 1:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86224/comment/d496525b_3ba63099?usp... :
PS1, Line 11:   
Nit: Seems there is an extra space.

https://review.coreboot.org/c/coreboot/+/86224/comment/367fe8a5_c182e6af?usp... :
PS1, Line 16: rely
Nit: relies

https://review.coreboot.org/c/coreboot/+/86224/comment/75ce56a8_1c7994f8?usp... :
PS1, Line 16: use
Nit: used

File src/soc/intel/alderlake/romstage/ux.c:

https://review.coreboot.org/c/coreboot/+/86224/comment/cef9979a_78c4af52?usp... :
PS1, Line 50: UX_MEMORY_TRAINING_DESC
Should it be a different locale name here instead of relying on memory training?

https://review.coreboot.org/c/coreboot/+/86224/comment/1615f3f8_64145ede?usp... :
PS1, Line 59: }
Looks like both `ux_inform_user_of_update_operation` and `user_inform_user_of_poweroff_operation` have identical implementation for the most part and a common helper function with the below signature can be defined.

```
static bool ux_inform_user_of_operation(const char *name, const char *ux_locale_desc, const char *default_text) {
...
}
```