[coreboot-gerrit] Change in coreboot[master]: Revert "soc/amd/common/espi: Don't set alert pin in espi_set_initial_...

[Raul Rangel (Code Review)]

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/53932 )

Change subject: Revert "soc/amd/common/espi: Don't set alert pin in espi_set_initial_config"
......................................................................

Revert "soc/amd/common/espi: Don't set alert pin in espi_set_initial_config"

This reverts commit 6eced03b25954e370e20e62f2cbe41f9d5626eae.

This prevents zork from booting. We get the following error:
eSPI cmd0-cmd2: 00080009 00000000 00000000 data: 00000000.
Error: unexpected eSPI status register bits set (Status = 0x10000010)
Error: Slave GET_CONFIGURATION failed!

This isn't a pure revert. It is more of a fix that keeps the old
behavior.

BUG=b:187122344
TEST=Boot zork an no longer see eSPI error

Signed-off-by: Raul E Rangel 
Change-Id: If75a35d3994b0fd23945a450032d3cc81abeb136
---
M src/soc/amd/common/block/lpc/espi_util.c
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/53932/1

diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c
index 81056b0..276bb3c 100644
--- a/src/soc/amd/common/block/lpc/espi_util.c
+++ b/src/soc/amd/common/block/lpc/espi_util.c
@@ -883,6 +883,17 @@
 {
    uint32_t espi_initial_mode = ESPI_OP_FREQ_16_MHZ | ESPI_IO_MODE_SINGLE;

+	switch (mb_cfg->alert_pin) {
+	case ESPI_ALERT_PIN_IN_BAND:
+		break;
+	case ESPI_ALERT_PIN_PUSH_PULL:
+	case ESPI_ALERT_PIN_OPEN_DRAIN:
+		espi_initial_mode |= ESPI_ALERT_MODE;
+		break;
+	default:
+		die("Unknown espi alert config: %u!\n", mb_cfg->alert_pin);
+	}
+
    espi_write32(ESPI_SLAVE0_CONFIG, espi_initial_mode);
 }