Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30992 )
Change subject: intel/apollolake: Add IPU to disable_dev function
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/30992/7/src/soc/intel/apollolake/chip.c@487
PS7, Line 487: silconfig->IpuEn = 0;
i'm not sure if any APL design is using MIPI camera and internal IPU if yes then this patch might impact. if you want to make something specific for mainboard alone then i believe adding things in chip.h and devicetree.cb to disable should be good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75444bf483de32ba641f76ca50e9744fdce2e726
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 7
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 09:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment