20 May
2019
20 May
'19
1:17 a.m.
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )
Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................
Patch Set 3: -Code-Review
(1 comment)
https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:
https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... PS3, Line 93: GPP_H0_IRQ it should be "GPP_H0", right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8
Gerrit-Change-Number: 32845
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Ben Kao ben.kao@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kane Chen kane.chen@intel.com
Gerrit-Reviewer: Naveen M naveen.m@intel.com
Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 May 2019 08:17:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment