Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32666 )
Change subject: mediatek/mt8183: Add md power off flow ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/#/c/32666/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32666/8//COMMIT_MSG@7 PS8, Line 7: power off power-off
https://review.coreboot.org/#/c/32666/8//COMMIT_MSG@10 PS8, Line 10: The SRCCLKENA is not used by mt8183, : so we can simply release it for suspend/resume to work. Please do not break the, just because there is a comma.
https://review.coreboot.org/#/c/32666/8//COMMIT_MSG@15 PS8, Line 15: Test=Boots correctly on Kukui, suspend test. Before it did not suspend or resume correctly?
https://review.coreboot.org/#/c/32666/8/src/soc/mediatek/mt8183/md_ctrl.c File src/soc/mediatek/mt8183/md_ctrl.c:
https://review.coreboot.org/#/c/32666/8/src/soc/mediatek/mt8183/md_ctrl.c@26 PS8, Line 26: /* Gating MD clock. */ Remove the dot at the end?
https://review.coreboot.org/#/c/32666/8/src/soc/mediatek/mt8183/md_ctrl.c@29 PS8, Line 29: /* Release SRCCLKENA. */ Ditto.
https://review.coreboot.org/#/c/32666/8/src/soc/mediatek/mt8183/md_ctrl.c@31 PS8, Line 31: INFRA_MISC2_SRCCLKENA_RELEASE); Doesn’t that fit on one line?