Attention is currently required from: Daniel Gröber (dxld).
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42612 )
Change subject: tests: Add stubs for spi tests
......................................................................
Patch Set 22:
(3 comments)
File tests/stubs/console/console.c:
PS22:
There already is implementation of (v)printk() stubs in tests/stubs/console.c
https://review.coreboot.org/c/coreboot/+/42612/comment/c693fcb5_6d84d682
PS22, Line 5: int do_printk(int msg_level, const char *fmt, ...)
Removed in CB:51887
https://review.coreboot.org/c/coreboot/+/42612/comment/844f2ac7_b3003002
PS22, Line 10: do_vprintk
Removed in CB:51887
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8513daf873d2b1faeece2e92190b7678b0572399
Gerrit-Change-Number: 42612
Gerrit-PatchSet: 22
Gerrit-Owner: Daniel Gröber (dxld)
coreboot@dxld.at
Gerrit-Reviewer: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Gröber
dxld@darkboxed.org
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Gröber (dxld)
coreboot@dxld.at
Gerrit-Comment-Date: Tue, 21 Feb 2023 13:17:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment