14 Dec
2020
14 Dec
'20
9:30 a.m.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44704 )
Change subject: soc/mediatek/mt8192: Do dramc software impedance calibration ......................................................................
Patch Set 40:
(1 comment)
Please address unresolved comments in PS1 and PS2.
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44704/2/src/soc/mediatek/mt8192/dra... PS2, Line 89: dramc_sw_impedance_cal
Please add this function to dramc_pi_api.h in this patch.
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/44704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c6ffe885717997540a0a9721310e355a3b6a87d
Gerrit-Change-Number: 44704
Gerrit-PatchSet: 40
Gerrit-Owner: CK HU ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 07:30:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment