Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33464 )
Change subject: mb/facebook/fbg1701: Add measured boot support
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg...
File src/mainboard/facebook/fbg1701/romstage.c:
https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg...
PS11, Line 79: if (CONFIG(VENDORCODE_ELTAN_MBOOT)
Is that still necessary because of line 57?
Removed
https://review.coreboot.org/c/coreboot/+/33464/11/src/mainboard/facebook/fbg...
PS11, Line 94: if (status)
: printk(BIOS_DEBUG, "Measure CRTM Version returned 0x%x\n",
: status);
Latest coding style will require bracket under if even single line.
Update to meet coding style
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33464
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5120ffb6af0b41520056e1773f63b7b2f34a2460
Gerrit-Change-Number: 33464
Gerrit-PatchSet: 12
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 10:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
lance.zhao@gmail.com
Gerrit-MessageType: comment