11 Nov
2019
11 Nov
'19
8:51 a.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: src/superio/nuvoton/nct5104d: soft reset GPIO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35482/1/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35482/1/src/superio/nuvoton/nct5104... PS1, Line 113: pnp_write_config(dev, LDN_SELECT_CR07, NCT5104D_GPIO);
pnp_set_logical_device will work with LDN 7, but not with LDN F. […]
just add the LDN 0xf to the device's devicetree then
--
To view, visit https://review.coreboot.org/c/coreboot/+/35482
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67878dbab2ddf0deaaa8f5d79416368c6164ba1d
Gerrit-Change-Number: 35482
Gerrit-PatchSet: 1
Gerrit-Owner: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Nov 2019 07:51:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com
Gerrit-MessageType: comment