25 Dec
2021
25 Dec
'21
9:21 p.m.
Attention is currently required from: AreYouLoco?, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42547 )
Change subject: cpu/intel/model_206ax: Add overclocking support ......................................................................
Patch Set 3:
(1 comment)
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/42547/comment/e3015883_5b3a2f29 PS3, Line 473: 0x206a3 This is not in the cpuid table. What are you trying to do? Should this apply to all IVB (0x306ax) and SNB stepping > 3? If so I think it would nice to make this explicit (maybe using get_fms).
--
To view, visit https://review.coreboot.org/c/coreboot/+/42547
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60bef32bfdde3c32a11f07afff64fc83d65fd3f1
Gerrit-Change-Number: 42547
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: AreYouLoco? areyouloco@paranoici.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: AreYouLoco? areyouloco@paranoici.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 25 Dec 2021 21:21:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment