[coreboot-gerrit] Change in coreboot[master]: rk3399: clock: Fix style for rkclk_ddr_reset()

[Angel Pons (Code Review)]

Attention is currently required from: Julius Werner, ron minnich.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51080 )

Change subject: rk3399: clock: Fix style for rkclk_ddr_reset()
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/soc/rockchip/rk3399/clock.c:

https://review.coreboot.org/c/coreboot/+/51080/comment/b5d208b6_ca1ef18a 
PS2, Line 253: #define RESETN_DDRPHY_REQ_SHIFT(ch)	(9 + (ch) * 4)
Would it make more sense to define and use these macros?

#define RESETN_DDR_REQ(ch, ctl)	((ctl) << RESETN_DDR_REQ_SHIFT(ch))
 #define RESETN_DDRPHY_REQ(ch, phy)	((phy) << RESETN_DDRPHY_REQ_SHIFT(ch))