Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56885 )
Change subject: mb/(amd,google): Update SPI Kconfig settings based on devicetree
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/56885/comment/4ca65044_db32bf94
PS5, Line 61: default 0 # 66MHz
Nit: Add a blank line between 2 config items.
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/56885/comment/5186159b_ff21f836
PS5, Line 110: config TPM_SPI_SPEED
: default 0 # 66MHz
:
Can we remove this since we don't use the TPM SPI interface on guybrush/zork?
All 4 different SPI speeds are configured using a single register - each 4 bits. The AMD common fch block API requires all 4 speeds be passed for configuration. That API needs to be updated if this were to become an optional configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icce1d57761465ae8255e5d9ce8679f3fdcb0ceed
Gerrit-Change-Number: 56885
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 17 Aug 2021 20:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment