Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/common: add processor power limits control support ......................................................................
Patch Set 24:
(10 comments)
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/acpi/... File src/soc/intel/common/acpi/dptf.asl:
PS22:
What made this file necessary?
This is required to add TCPU zone for thermal control.
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 28: Used to configure
Ok
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 33: uint32_t
I would consider to use uint16_t considering the need in the future.
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 35: tdp_pl2_override
planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 37: tdp_psyspl2
same as above, planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 39: tdp_psyspl3
same as above, planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 41: tdp_psyspl3_time
same as above, planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 43: tdp_psyspl3_dutycycle
same as above, planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 45: tdp_pl4
same as above planning to use uint16_t
Done
https://review.coreboot.org/c/coreboot/+/39346/22/src/soc/intel/common/block... PS22, Line 47: psys_pmax
same as above planning to use uint16_t
Done