[coreboot-gerrit] [XS] Change in coreboot[main]: mb/amb/birman*: gpio.c

[Felix Held (Code Review)]

Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk.

Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85498?usp=email )

Change subject: mb/amb/birman*: gpio.c
......................................................................

Patch Set 1:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85498/comment/95a50b92_08935416?usp... :
PS1, Line 7: mb/amb/birman*: gpio.c
maybe:
mb/amb/birman*/gpio: use native functions for VDD_MEM_VID[0,1]

File src/mainboard/amd/birman/gpio.c:

https://review.coreboot.org/c/coreboot/+/85498/comment/b2558859_635cbe8f?usp... :
PS1, Line 33: PULL_NONE
from the schematic, i'd expect this to be PULL_UP. same for the other instances