Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34904 )
Change subject: mb/asrock/h110m: Add STX variant ......................................................................
Patch Set 4:
(3 comments)
Patch Set 4:
(4 comments)
Thanks for the review
https://review.coreboot.org/c/coreboot/+/34904/4/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/Kconfig:
https://review.coreboot.org/c/coreboot/+/34904/4/src/mainboard/asrock/h110m/... PS4, Line 17: BOARD_ASROCK_H110M_DVS
Doesn't the H110M-STX use a NCT6791D as well?
No, this board uses NCT5567D
https://review.coreboot.org/c/coreboot/+/34904/4/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/34904/4/src/mainboard/asrock/h110m/... PS4, Line 25: if (CONFIG(BOARD_ASROCK_H110M_DVS)) {
I would suggest changing the if condition: https://github. […]
This is a temporary solution. The board has a Nuvoton nct5567D . If I am not mistaken, then this chip has the same registers as the NCT5539D, https://review.coreboot.org/c/coreboot/+/33842
https://review.coreboot.org/c/coreboot/+/34904/4/src/mainboard/asrock/h110m/... File src/mainboard/asrock/h110m/variants/dvs/overridetree.cb:
PS4:
You would want to rebase this change atop the ones that change this devicetree
Yes, but first, I should to fix device tree for the dvs variant