Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35366 )
Change subject: mb/google/drallion: add sku id base on sensor detection ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35366/2/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/sku.c:
https://review.coreboot.org/c/coreboot/+/35366/2/src/mainboard/google/dralli... PS2, Line 4: 2018 2019
https://review.coreboot.org/c/coreboot/+/35366/2/src/mainboard/google/dralli... PS2, Line 25: (gpio_get(GPP_H5) | (wilco_ec_signed_fw() << 1)) Make a function called get_sku_index or something like that.