3 Dec
2019
3 Dec
'19
2:33 p.m.
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37402 )
Change subject: amdblocks/acpimmio: Unify BIOSRAM usage ......................................................................
Patch Set 8: Code-Review+2
Patch Set 7: Code-Review+2
Patch Set 7:
I don't see the changes done to hudson and sb800 as working, as I don't see a change in their makefile.inc to use the common code. IIRC, you're only getting away with it because Kyosti disabled the build of several old AMD platforms, hudson and sb800 included...
The change to use common code is already in with previous "select SOC_AMD_COMMON_ACPIMMIO" for these platforms. All AGESA boards still build.
Well, in this case, I agree... approved.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a03e4f01d7fb2ffc9f8b5af73d7e4e7ec027da
Gerrit-Change-Number: 37402
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Dec 2019 14:33:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment