build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42238 )
Change subject: Revert "Redo testbios utility to use all of YABEL" ......................................................................
Patch Set 1:
(136 comments)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.h File util/vgabios/helper_exec.h:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.h@... PS1, Line 30: u8 bios_checksum(u8 * start, int size); "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c File util/vgabios/helper_exec.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c@... PS1, Line 1: /* $XFree86: xc/programs/Xserver/hw/xfree86/int10/helper_exec.c,v 1.16 2001/04/30 14:34:57 tsi Exp $ */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c@... PS1, Line 48: printf("%s: INT %x CS:IP = %x:%x\n", __FUNCTION__, __func__ should be used instead of gcc specific __FUNCTION__
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c@... PS1, Line 217: u8 bios_checksum(u8 * start, int size) "foo * bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c@... PS1, Line 233: * restore the original values afterwards. In beween we hold our 'beween' may be misspelled - perhaps 'between'?
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_exec.c@... PS1, Line 234: * breath. To get to a (possibly exising) ISA card need to disable 'exising' may be misspelled - perhaps 'existing'?
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c File util/vgabios/helper_mem.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@1 PS1, Line 1: /* $XFree86: xc/programs/Xserver/hw/xfree86/int10/helper_mem.c,v 1.21 2001/05/22 16:24:37 tsi Exp $ */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@4... PS1, Line 40: printf("%c", ((((unsigned char) (*c)) > 32) && (((unsigned char) (*c)) < 128)) ? line over 96 characters
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@1... PS1, Line 191: if (((pEnt->index < 0) || do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@1... PS1, Line 198: if (!(options = (OptionInfoPtr) xalloc(sizeof(INT10Options)))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@2... PS1, Line 295: if ((p = strchr(p, ':'))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/helper_mem.c@2... PS1, Line 297: if ((p = strchr(p, ':'))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int10.c File util/vgabios/int10.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int10.c@163 PS1, Line 163: if (X86_BH != MEM_RB(0x0462)) Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c File util/vgabios/int1a.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@32 PS1, Line 32: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@41 PS1, Line 41: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@45 PS1, Line 45: else if ((pvp = xf86FindPciDeviceVendor(X86_EDX, X86_ECX, X86_ESI, pvp))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@47 PS1, Line 47: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@53 PS1, Line 53: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@61 PS1, Line 61: if (X86_CL == pvp->interface && Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@62 PS1, Line 62: X86_CH == pvp->subclass && Comparisons should place the constant on the right side of the test
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@66 PS1, Line 66: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@70 PS1, Line 70: if (0); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@73 PS1, Line 73: else if ((pvp = FindPciClass(X86_CL, X86_CH, do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@77 PS1, Line 77: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@83 PS1, Line 83: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@90 PS1, Line 90: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@93 PS1, Line 93: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@96 PS1, Line 96: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@103 PS1, Line 103: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@106 PS1, Line 106: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@109 PS1, Line 109: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@116 PS1, Line 116: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@119 PS1, Line 119: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@122 PS1, Line 122: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@129 PS1, Line 129: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@132 PS1, Line 132: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@135 PS1, Line 135: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@142 PS1, Line 142: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@145 PS1, Line 145: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@148 PS1, Line 148: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@155 PS1, Line 155: if ((tag = findPci(X86_EBX))) { do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@158 PS1, Line 158: X86_EFLAGS &= ~((unsigned long) 0x01); /* clear carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/int1a.c@161 PS1, Line 161: X86_EFLAGS |= ((unsigned long) 0x01); /* set carry flag */ Unnecessary typecast of c90 int constant
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/inte6.c File util/vgabios/inte6.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/inte6.c@9 PS1, Line 9: if ((pvp = xf86GetPciInfoForEntity(pInt->entityIndex))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... File util/vgabios/pci-userspace.h:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 33: void *aux; /* Auxillary data */ 'Auxillary' may be misspelled - perhaps 'Auxiliary'?
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... File util/vgabios/pci-userspace.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 7: #define LIBPCI_CHECK_VERSION(major,minor,micro) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 7: #define LIBPCI_CHECK_VERSION(major,minor,micro) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 8: ((((major) << 16) | ((minor) << 8) | (micro)) <= PCI_LIB_VERSION) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 10: #define LIBPCI_CHECK_VERSION(major,minor,micro) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 10: #define LIBPCI_CHECK_VERSION(major,minor,micro) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 11: ( (LIBPCI_MAJOR_VERSION > (major)) || \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 11: ( (LIBPCI_MAJOR_VERSION > (major)) || \ space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 12: (LIBPCI_MAJOR_VERSION == (major) && LIBPCI_MINOR_VERSION > (minor)) || \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 13: (LIBPCI_MAJOR_VERSION == (major) && LIBPCI_MINOR_VERSION == (minor)) && \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 14: LIBPCI_MICRO_VERSION >= (micro) ) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 14: LIBPCI_MICRO_VERSION >= (micro) ) space prohibited before that close parenthesis ')'
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 59: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 59: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 77: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 77: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 78: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 80: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 93: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 93: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 94: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 96: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 109: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 109: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 110: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 112: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 126: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 126: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 127: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 129: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 142: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 142: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 143: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 145: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 159: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 159: #if LIBPCI_CHECK_VERSION(2,1,99) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 160: if ((d = pci_get_dev(pacc, 0, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/pci-userspace.... PS1, Line 162: if ((d = pci_get_dev(pacc, tag->bus, tag->slot, tag->func))) do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h File util/vgabios/testbios.h:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@81 PS1, Line 81: u8(*rb) (ptr, int); missing space after return type
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@81 PS1, Line 81: u8(*rb) (ptr, int); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@81 PS1, Line 81: u8(*rb) (ptr, int); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@81 PS1, Line 81: u8(*rb) (ptr, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@82 PS1, Line 82: u16(*rw) (ptr, int); missing space after return type
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@82 PS1, Line 82: u16(*rw) (ptr, int); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@82 PS1, Line 82: u16(*rw) (ptr, int); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@82 PS1, Line 82: u16(*rw) (ptr, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@83 PS1, Line 83: u32(*rl) (ptr, int); missing space after return type
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@83 PS1, Line 83: u32(*rl) (ptr, int); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@83 PS1, Line 83: u32(*rl) (ptr, int); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@83 PS1, Line 83: u32(*rl) (ptr, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@84 PS1, Line 84: void (*wb) (ptr, int, u8); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@84 PS1, Line 84: void (*wb) (ptr, int, u8); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@84 PS1, Line 84: void (*wb) (ptr, int, u8); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@84 PS1, Line 84: void (*wb) (ptr, int, u8); function definition argument 'u8' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@85 PS1, Line 85: void (*ww) (ptr, int, u16); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@85 PS1, Line 85: void (*ww) (ptr, int, u16); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@85 PS1, Line 85: void (*ww) (ptr, int, u16); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@85 PS1, Line 85: void (*ww) (ptr, int, u16); function definition argument 'u16' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@86 PS1, Line 86: void (*wl) (ptr, int, u32); Unnecessary space before function pointer arguments
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@86 PS1, Line 86: void (*wl) (ptr, int, u32); function definition argument 'ptr' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@86 PS1, Line 86: void (*wl) (ptr, int, u32); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@86 PS1, Line 86: void (*wl) (ptr, int, u32); function definition argument 'u32' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.h@89 PS1, Line 89: #define MEM_WB(where, what) wrb(where,what) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c File util/vgabios/testbios.c:
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@49 PS1, Line 49: if (getIntVect(num) == 0xFF065) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@105 PS1, Line 105: ("Usage: %s [-c codesegment] [-s size] [-b base] [-i ip] [-t] <filename> ... \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@192 PS1, Line 192: printf("Unknown option \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@342 PS1, Line 342: unsigned short devfn=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@343 PS1, Line 343: long bus=0,dev=0,fn=0,need_pack=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@346 PS1, Line 346: tok = strsep(&arg_val,":"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@348 PS1, Line 348: bus = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@348 PS1, Line 348: bus = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@351 PS1, Line 351: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@355 PS1, Line 355: tok = strsep(&arg_val,"."); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@357 PS1, Line 357: dev = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@357 PS1, Line 357: dev = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@358 PS1, Line 358: fn = strtol(arg_val,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@358 PS1, Line 358: fn = strtol(arg_val,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@361 PS1, Line 361: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@362 PS1, Line 362: if (need_pack ==1 && (strlen(tok))) { spaces required around that '==' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@362 PS1, Line 362: if (need_pack ==1 && (strlen(tok))) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@363 PS1, Line 363: dev = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@363 PS1, Line 363: dev = strtol(tok,0,16); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@367 PS1, Line 367: if ( need_pack == 1) { space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@367 PS1, Line 367: if ( need_pack == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@370 PS1, Line 370: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/42238/1/util/vgabios/testbios.c@383 PS1, Line 383: printf ("<%d> ", msg_level); space prohibited between function name and open parenthesis '('