Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36135 )
Change subject: nb/intel/nehalem: Fix 'dead increment'
......................................................................
Patch Set 1:
The rest of the code that uses that variable is this... thing:
if (info->revision_flag_1) {
if (some_delay_3_ps < 150)
some_delay_3_halfcycles = 0;
else
some_delay_3_halfcycles = (some_delay_3_ps << 6) / halfcycle_ps(info);
some_delay_3_ps_rounded = halfcycle_ps(info) * some_delay_3_halfcycles >> 6;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8133f9e8786006bd278d281a132b6a2bd863a967
Gerrit-Change-Number: 36135
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 01 Nov 2019 12:01:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment