Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46268 )
Change subject: mb/intel: Get rid of power button device in coreboot
......................................................................
Patch Set 2:
Patch Set 2:
a git grep "Device.*PWRB" -- *.asl shows more mainboards than this.
what about baskingridge, d945gclf, emeraldlake2, harcuvar, strago, and wtm2 ?
I think it would be better to handle these older boards in a separate patch. It's not so easy to test them, I believe.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f9d73048041d42d809750fdb52092f40ab8f11f
Gerrit-Change-Number: 46268
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:57:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment