build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67527 )
Change subject: [WIP] mb/aaeon: Add Atomic Pi ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/aaeon/atomic_pi/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158451): https://review.coreboot.org/c/coreboot/+/67527/comment/0ad1fb76_2ac7555b PS1, Line 7: #if 0 Consider removing the code enclosed by this #if 0 and its #endif
File src/mainboard/aaeon/atomic_pi/irqroute.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158451): https://review.coreboot.org/c/coreboot/+/67527/comment/b4c12eed_8112c68a PS1, Line 7: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158451): https://review.coreboot.org/c/coreboot/+/67527/comment/8400337a_fdecb4f4 PS1, Line 18: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses