Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Subrata Banik, EricR Lai.
Matt Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
I suggest you can add log in sar.c as well. […]
I think it might be as you assumed somewhere around that overwrites it, but does that mean my patch here is good way to make it back to right one in the end, which is MAX_DSAR_SET_COUNT ?
The 3 is also our driver expects as you can tell in below code comment:
static void sar_emit_ewrd(const struct sar_profile *sar)
....
/* wifi driver always expects 3 DSAR sets */
for (i = 0; i < (table_size * (MAX_DSAR_SET_COUNT - sar->dsar_set_count)); i++)
acpigen_write_byte(0);
....
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 11 Nov 2021 15:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment