Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38779 )
Change subject: vboot: push clear recovery mode switch until BS_WRITE_TABLES ......................................................................
Patch Set 3:
(1 comment)
You cannot assume that there's an EC in the system, this needs to work when the recovery mode switch is implemented by a different backend as well. So you'll want to put a
BOOT_STATE_INIT_ENTRY(BS_WRITE_TABLES, BS_ON_ENTRY, clear_recovery_mode_switch, NULL);
into vboot/bootmode.c, so that it gets called in all cases. For configurations that don't override clear_recovery_mode_switch(), that will simply be a no-op. chromeec/switches.c should override that function to do the logging and the clearing for the EC.
https://review.coreboot.org/c/coreboot/+/38779/3/src/mainboard/intel/galileo... File src/mainboard/intel/galileo/vboot.c:
https://review.coreboot.org/c/coreboot/+/38779/3/src/mainboard/intel/galileo... PS3, Line 27: int clear_recovery_mode_switch(void) nit: unrelated, but this could also be removed (there's a weak stub in security/vboot already). Same for intel/kblrvp.