Attention is currently required from: Philipp Hug, ron minnich, HAOUAS Elyes. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50167 )
Change subject: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h> ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50167/comment/7aef98a0_cada15ac PS3, Line 7: arch/{arm,riscv}/boot.c: Add missing <commonlib/bsd/cbfs_serialized.h> It isn't missing. People use coreboot headers like <cbfs.h> to chain-include commonlib headers like <commonlib/bsd/cbfs.h> intentionally because it hides the implementation detail of which parts are factored out into shared code trees, making it easier to refactor those later.
I feel like we've had this discussion a dozen times now? Whenever I mention this you abandon the patch implying you agree but then you just reupload the same thing again elsewhere a month later? If you disagree then please, let's have that discussion, but please don't just make me chase your submissions and write the same thing over and over again. It's tiresome and a waste of both our time. :/