Attention is currently required from: Elyes Haouas, Maximilian Brune, Shuo Liu.
Hello Maximilian Brune, Shuo Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85786?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Shuo Liu, Code-Review+2 by Maximilian Brune, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: util/cbfstool: Refine type and signatures ......................................................................
util/cbfstool: Refine type and signatures
As suggested by the linter:
Prefer 'unsigned long' over 'unsigned long int' as the int is unnecessary
In fmap_bsearch(), offset being negative, changed its type to 'long', and the return value of to 'long'.
fmap_find() uses the return value of fmap_bsearch(); and is declared as 'long int'. Per the linter warnings, replaced 'long int' by 'long'.
Prefer 'long' over 'long int' as the int is unnecessary
Link: https://qa.coreboot.org/job/coreboot-untested-files/lastSuccessfulBuild/arti... Cc: Nico Huber nico.h@gmx.de Cc: Julius Werner jwerner@chromium.org Cc: "Jérémy Compostella" jeremy.compostella@intel.com Cc: Ron Minnich rminnich@gmail.com Cc: Shuo Liu shuo.liu@intel.com Cc: Arthur Heymans arthur@aheymans.xyz Cc: Patrick Georgi patrick@coreboot.org Cc: Elyes Haouas ehaouas@noos.fr Change-Id: If94e70778d0302552f151c31d3073524162faf9e Signed-off-by: Ariel Otilibili otilibil@eurecom.fr --- M util/cbfstool/cbfstool.c M util/cbfstool/flashmap/fmap.c 2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/85786/2