Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48122 )
Change subject: mb/intel/ehlcrb: Remove IPU & MIPI related support from EHL CRB ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48122/2/src/mainboard/intel/elkhart... File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48122/2/src/mainboard/intel/elkhart... PS2, Line 31: end
Would you mind to add a comment here which describes this PCI device? Just like the other already do […]
Done. Removed this part due to this is not available for EHL CRB due to it is for MIPI camera on JSL.
https://review.coreboot.org/c/coreboot/+/48122/2/src/mainboard/intel/elkhart... PS2, Line 167: I2C
A I2C controller number would be nice here. Should be I2C #4 and I2C #5 if I am not mistaken.
Done