Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons, Arthur Heymans, Kyösti Mälkki, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52520 )
Change subject: soc/intel/broadwell/pch: Replace ACPI device NVS
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File src/soc/intel/broadwell/pch/acpi.c:
https://review.coreboot.org/c/coreboot/+/52520/comment/bb77b8ce_045acc8f
PS9, Line 17: 8
nit: `BITS_PER_BYTE` is in types.h now
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52520
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89fb658fbb10a8769ebea2e6535c45cd7c212d06
Gerrit-Change-Number: 52520
Gerrit-PatchSet: 9
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:20:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment