Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/...
PS1, Line 34: echo <<EOF >variants/${variant,,}/include/variant/acpi/dptf.asl
it feels a little weird for all of the templates to live in this script. […]
Yeah, I don't especially like it either, but it was good-enough to get something started. I would much prefer to use separate template files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5b9c8735faafebb2e4e384cb3346867d64c556
Gerrit-Change-Number: 35239
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 03 Sep 2019 19:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jett Rink
jettrink@chromium.org
Gerrit-MessageType: comment