Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44038 )
Change subject: soc/intel/tigerlake: Add chipset devicetree
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco...
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44038/3/src/soc/intel/tigerlake/Kco...
PS3, Line 95:
right, but that doesn't show what selected it. […]
It doesn't need it selected to compile, because all this will do is set up a `struct drivers_intel_wifi_config` with some fields already set, which doesn't require the Kconfig (and thus the .c file to be compiled in), only the header file, which is still accessible. We don't necessarily want to force all Tiger Lake mainboards to have Intel WiFi.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44038
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If50269808645ddc019e0d94fa8296df58ab7c367
Gerrit-Change-Number: 44038
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 19:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment