[coreboot-gerrit] [M] Change in coreboot[main]: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.

Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85634?usp=email )

Change subject: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
......................................................................

Patch Set 15:

(3 comments)

Patchset:

PS15: 
only had a very brief look

File src/drivers/amd/opensil/memmap.c:

https://review.coreboot.org/c/coreboot/+/85634/comment/cebda5c3_287c362d?usp... :
PS15, Line 16: } HOLE_INFO;
please add a comment to this struct that it matches and needs to match openSIL's MEMORY_HOLE_TYPES struct

https://review.coreboot.org/c/coreboot/+/85634/comment/208a1e3b_a293c933?usp... :
PS15, Line 18: // This assumes holes are allocated
since this code is moved from vendorcode into the regular coreboot code base, it would be better to update the comment style to the one used in coreboot:

/* */