HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33913 )
Change subject: src/mainboard/asus/am1i-a/buildOpts.c: reorder lines for comparison convenience
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33913/1/src/mainboard/asus/am1i-a/buildOpts....
File src/mainboard/asus/am1i-a/buildOpts.c:
https://review.coreboot.org/#/c/33913/1/src/mainboard/asus/am1i-a/buildOpts....
PS1, Line 143:
Other board didn't have it and omitting "ul" does not cause any difference. […]
I have no idea if you should or not.
it was just a question
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1674252fab2fc6fbf9be2b37e97a6f5ff97a04b3
Gerrit-Change-Number: 33913
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 30 Jun 2019 18:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment