Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45560 )
Change subject: soc/intel/common/basecode: Move block/acpi to basecode/acpi ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/acpi.... File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/acpi.... PS6, Line 201: unsigned long acpi_fill_mcfg(unsigned long current) Why are all these things being moved around in skylake? I think those should be done separately from the acpi movement from block/ to basecode/
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/inclu... File src/soc/intel/skylake/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/inclu... PS6, Line 9: /* P-state configuration */ Why did these move?
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/pmuti... File src/soc/intel/skylake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/45560/6/src/soc/intel/skylake/pmuti... PS6, Line 116: acpi_sci_irq Why did this get dropped?