Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/55407 )
Change subject: mb/google/dedede/var/kracko: Configure I2C high and low times ......................................................................
mb/google/dedede/var/kracko: Configure I2C high and low times
Configure I2C high / low time in device tree to ensure I2C CLK runs under I2C_SPEED_FAST (400 kHz).
Touchpad: 387.7kHz Touchscreen: 389.4kHz Audio: 387.6kHz P-sensor: 372.5kHz
BaUG=b:178092096 BRANCH=dedede TEST=Build and EE check after tuning I2C clock is under 400kHz
Change-Id: I4f6bdd3802cd94671325a89458cde981a2ffa929 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/55407 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/kracko/overridetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Angel Pons: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/kracko/overridetree.cb b/src/mainboard/google/dedede/variants/kracko/overridetree.cb index 3d9307b..dec4c0a 100644 --- a/src/mainboard/google/dedede/variants/kracko/overridetree.cb +++ b/src/mainboard/google/dedede/variants/kracko/overridetree.cb @@ -35,18 +35,26 @@ }, .i2c[0] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 212, + .fall_time_ns = 38, }, .i2c[1] = { .speed = I2C_SPEED_FAST, }, .i2c[2] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 212, + .fall_time_ns = 38, }, .i2c[4] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 212, + .fall_time_ns = 38, }, .i2c[5] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 212, + .fall_time_ns = 38, }, }"