EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36519 )
Change subject: soc/intel/cannonlake: Disable USB2 PHY Power gating
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36519/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36519/3//COMMIT_MSG@9
PS3, Line 9: Workaround for an issue seen when a specific charger is connected while
: in S0ix state
Which charger? What was the issue that this solves?
Ack
https://review.coreboot.org/c/coreboot/+/36519/4/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/36519/4/src/mainboard/google/dralli...
PS4, Line 41: register "PchUsb2PhySusPgEnable" = "1"
drallion has this issue as well. Need client to decide need this or not.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95909c73de758fccc7f616a330c1e1f0667e8c25
Gerrit-Change-Number: 36519
Gerrit-PatchSet: 13
Gerrit-Owner: Surendranath R Gurivireddy
surendranath.r.gurivireddy@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Surendranath R Gurivireddy
surendranath.r.gurivireddy@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Nov 2019 13:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment