Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36550 )
Change subject: soc/intel/tigerlake/bootblock: Do initial SoC commit till bootblock ......................................................................
Patch Set 7:
(2 comments)
It would be nice to have the following documented in the commit messages of the copy-paste commits: For each added function or selected Kconfig, if
* the respective function or guarded code was reviewed to be compatible with Tiger Lake or * if there will be a follow up commit adapting it, also if * the respective function or guarded code was tested specifically.
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG@23 PS7, Line 23: from an authoritative internal source. What is this supposed to mean? And why can't you share the document numbers? It makes it look like you don't want people to read documentation.
https://review.coreboot.org/c/coreboot/+/36550/7//COMMIT_MSG@25 PS7, Line 25: The patch has been tested on real hardware." What does this mean? what would be non-real hardware? Please be more specific, how was it tested? I assume at the end of the still hidden, yet to be reviewed (hence, still in flux) patch train? also, what was tested exactly? if it boots? if every single function works?