[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update ACPI files

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )

Change subject: soc/intel/tigerlake: Update ACPI files
......................................................................

Patch Set 16: Code-Review+1

(4 comments)

https://review.coreboot.org/c/coreboot/+/37781/15//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37781/15//COMMIT_MSG@12 
PS15, Line 12:
> also mentioned that you have use ASL2. […]

Ack

https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... 
File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:

https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... 
PS15, Line 20: PCR_BASE_ADDRESS
> don't need if required use CONFIG_PCR_BASE_ADDRESS directly

Ack

https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... 
PS15, Line 21: 0xAD0000
> You don't need this

Ack

https://review.coreboot.org/c/coreboot/+/37781/15/src/soc/intel/tigerlake/ac... 
PS15, Line 25: OperationRegion (ICLK, SystemMemory, PCR_BASE_ADDRESS + ICLK_PCR_OFFSET, 0x40)
> you can use this rather those hardcoding logic […]

Ack