Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35553 )
Change subject: util/mainboard/google: Fix hatch variant script
......................................................................
Patch Set 1:
+1 to all of amcrae@'s comments.
Please note that these scripts are still in the very early stage. There is some ongoing discussion with the build team about support responsibilities, and this script (along with others in the main chromimumos tree) may get moved wholesale into another location, rather than living in the trees that they modify.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35553
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6f4179014b79ea45d0fcf406ca192046438dbf7
Gerrit-Change-Number: 35553
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Andrew McRae
amcrae@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-Comment-Date: Tue, 24 Sep 2019 13:16:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment