Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45286 )
Change subject: amdfwtool: Clean up the Makefile of amdfwtool ......................................................................
Patch Set 10:
(3 comments)
Patch Set 9:
(5 comments)
compiling the standalone version fails with this:
felix@felix-VirtualBox:~/coreboot/util/amdfwtool$ make cc -O2 -Wall -Wextra -Wshadow -Wno-sign-compare -c -o amdfwtool.o amdfwtool.c amdfwtool.c: In function ‘main’: amdfwtool.c:1756:3: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] write(targetfd, amd_romsig, ctx.current - romsig_offset); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc amdfwtool.o -o amdfwtool
https://review.coreboot.org/c/coreboot/+/45286/7/util/amdfwtool/Makefile.inc File util/amdfwtool/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45286/7/util/amdfwtool/Makefile.inc... PS7, Line 1: #***************************************************************************** : # : # All rights reserved. : #
remove
Done
https://review.coreboot.org/c/coreboot/+/45286/7/util/amdfwtool/Makefile.inc... PS7, Line 6: # : #*****************************************************************************
remove
Done
https://review.coreboot.org/c/coreboot/+/45286/7/util/amdfwtool/Makefile.inc... PS7, Line 9: #data_parse.o
remove; that one gets added in the next patch, so no need to have a commented out version here
Done