[coreboot-gerrit] Patch set updated for coreboot: 84ce0eb inteltool: Allow to override Makefile variables

[Paul Menzel]

Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2996

-gerrit

commit 84ce0eba178ee7636e7f333350bb60294ca7c1d6
Author: Paul Menzel 
Date:   Sun Mar 31 22:15:43 2013 +0200

inteltool: Allow to override Makefile variables

Allow to override the variables `CC`, `INSTALL`, `PREFIX`,
    `CFLAGS` and `LDFLAGS`. Though append `-lpci -lz` to `LDFLAGS`.

This way for example a different compiler can easily be used.

CC=clang make

As a side note, Clang in contrast to GCC does *not* issue the
    following warnings.

$ clang --version
        Debian clang version 3.2-1~exp6 (tags/RELEASE_32/final) (based on LLVM 3.2)
        Target: i386-pc-linux-gnu
        Thread model: posix
        $ gcc --version
        gcc-4.7.real (Debian 4.7.2-15) 4.7.2
        Copyright (C) 2012 Free Software Foundation, Inc.
        This is free software; see the source for copying conditions.  There is NO
        warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
        $ make
        […]
        amb.c: In function ‘amb_read_config32’:
        amb.c:31:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:31:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config16’:
        amb.c:45:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:45:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        amb.c: In function ‘amb_read_config8’:
        amb.c:60:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
        amb.c:60:10: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
        […]

These are only shown under 32-bit and not 64-bit

$ uname -m
        i686

and are going to be fixed in a separate patch.

Change-Id: Id75dea081ecb35390f283520a7e5dce520f4c98d
    Signed-off-by: Paul Menzel 
---
 util/inteltool/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/util/inteltool/Makefile b/util/inteltool/Makefile
index 6c94460..2028a4a 100644
--- a/util/inteltool/Makefile
+++ b/util/inteltool/Makefile
@@ -21,17 +21,17 @@

PROGRAM = inteltool

-CC      = gcc
-INSTALL = /usr/bin/install
-PREFIX  = /usr/local
-CFLAGS  = -O2 -g -Wall -W
-LDFLAGS = -lpci -lz
+CC      ?= gcc
+INSTALL ?= /usr/bin/install
+PREFIX  ?= /usr/local
+CFLAGS  ?= -O2 -g -Wall -W
+LDFLAGS += -lpci -lz

OBJS = inteltool.o cpu.o gpio.o rootcmplx.o powermgt.o memory.o pcie.o amb.o

OS_ARCH	= $(shell uname)
 ifeq ($(OS_ARCH), Darwin)
-LDFLAGS = -framework DirectHW -lpci -lz
+LDFLAGS += -framework DirectHW
 endif
 ifeq ($(OS_ARCH), FreeBSD)
 CFLAGS += -I/usr/local/include