Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62172 )
Change subject: nb/intel/gm45/pm.c: Make clang happy ......................................................................
nb/intel/gm45/pm.c: Make clang happy
Clang complains that the terniary '?' operator is executed before the bitwise '|'. This is true and desired in this case. Being explicit about won't hurt however.
Change-Id: I27d1fc1c19e1dab3d1c82e407151eaa46f8c7b03 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/62172 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M src/northbridge/intel/gm45/pm.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved
diff --git a/src/northbridge/intel/gm45/pm.c b/src/northbridge/intel/gm45/pm.c index f1b7abc..656a632 100644 --- a/src/northbridge/intel/gm45/pm.c +++ b/src/northbridge/intel/gm45/pm.c @@ -171,7 +171,7 @@ mchbar_setbits32(0xf80, 1 << 31);
mchbar_write32(0x40, (mchbar_read32(0x40) & ~(0x3f << 24)) | - (sysinfo->cores == 4) ? (1 << 24) : 0); + ((sysinfo->cores == 4) ? (1 << 24) : 0));
mchbar_clrbits32(0x40, 1 << 19); mchbar_setbits32(0x40, 1 << 13);