Attention is currently required from: Alexander Couzens, Keith Hui.
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76962?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: SNB+MRC boards: Do not redo PEI data struct in hook ......................................................................
SNB+MRC boards: Do not redo PEI data struct in hook
For Sandy Bridge boards implementing mainboard_fill_pei_data() for MRC raminit, fill only data values unavailable elsewhere, rather than overwriting the entire PEI data structure again.
Values that can be set from devicetree are moved there as well, since they will be populated by devicetree_fill_pei_data() in northbridge code. Examples include, but not limited, to:
ec_present max_ddr3_freq (via register "max_mem_clock_mhz") gbe_enable (by way of whether gbe device is enabled in devicetree)
Some boards have max_mem_clock_mhz set to 666 (which is used by native raminit as well, but would result in max_ddr3_freq in MRC PEI data set to 1333), yet have max_ddr3_freq to 1600. These values are retained but a TODO is added that this should be addressed later.
This is done to not interfere with upcoming transition to one standard Haswell way of providing SPD info to northbridge.
Change-Id: Ie349a8f400eecca3cdbc196ea0790aebe0549e39 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p8x7x-series/devicetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/link/devicetree.cb M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/devicetree.cb M src/mainboard/google/stout/early_init.c M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/dcp847ske/romstage.c M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/x220/devicetree.cb M src/mainboard/lenovo/x220/early_init.c M src/mainboard/roda/rv11/variants/rv11/devicetree.cb M src/mainboard/roda/rv11/variants/rv11/early_init.c M src/mainboard/roda/rv11/variants/rw11/devicetree.cb M src/mainboard/roda/rv11/variants/rw11/early_init.c M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/early_init.c 25 files changed, 343 insertions(+), 570 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/76962/2