Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34356 )
Change subject: ec/google/chromeec: Pass reference of object to BBST() method ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/34356/1/src/ec/google/chromeec/acpi... PS1, Line 198: Store (Local1, Arg2)
I guess statements like this should only be valid if Arg2 (which is an input) is a RefOf?
I think it is still valid to store to a local copy of Arg2 (treating it as another local variable) but if you didn't realize it was pass by value and was not a reference it may not have the intended effect.