Attention is currently required from: Felix Singer, Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Srinidhi N Kaushik, Raj Astekar, Nathaniel L Desimone.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 )
Change subject: soc/intel/tigerlake: Hook up FSP repository
......................................................................
Patch Set 15:
(2 comments)
File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/48713/comment/131a309e_51cc5237
PS15, Line 23: FSP_TYPE_CLIENT
Since the default FSP type is FSP_TYPE_CLIENT, there is no need to explicitly select this at the mai […]
I agree.
File src/soc/intel/tigerlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/48713/comment/a35e112b_e4986598
PS15, Line 220: depends on HAVE_INTEL_FSP_REPO
This is not really a dependency, right?
`HAVE_INTEL_FSP_REPO` is always selected now, so we might as well remove the dependency.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e694b91be7734dd98665051a6a3d9eccab7dac7
Gerrit-Change-Number: 48713
Gerrit-PatchSet: 15
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.corp-partner.google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Sat, 05 Jun 2021 09:21:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment