Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40808 )
Change subject: soc/amd/picasso/Makefile: Verify bootblock size is power of two ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40808/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40808/3//COMMIT_MSG@10 PS3, Line 10: This is because MTRRs have this requirement. You could have just aligned _bootblock in CB:38691 to meet MTRR requirements? Admittedly, for picasso bootblock is compressed in the flash, but worst-case you are almost doubling the DRAM reserve.
Related bug, fixing of which might remove bootblock size reference from the Makefile: https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/Makefi...