Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45536 )
Change subject: soc/intel/{cnl,icl,tgl,jsl,ehl,adl}/acpi: generate CPPC entries
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45536/10/src/soc/intel/alderlake/ac...
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/45536/10/src/soc/intel/alderlake/ac...
PS10, Line 162: generate_cppc_entries(core_id);
Why jump through so many hoops here? soc calls generate_cpu_entries(), calls
back here, calls back there. I guess the hardware involves the soc-specific
config struct, but then again, why is it a devicetree config?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45536
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40d47d18a35002bc9ec55473e94277d89fc5797e
Gerrit-Change-Number: 45536
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 13 Oct 2020 16:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment