[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Do initial SoC commit

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )

Change subject: soc/intel/tigerlake: Do initial SoC commit
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/acp... 
File src/soc/intel/tigerlake/acpi/espi.asl:

https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/acp... 
PS8, Line 95: Device (RTC)
            : 	{
            : 		Name (_HID, EISAID ("PNP0B00"))
            : 		Name (_DDN, "Real Time Clock")
            : 		Name (_CRS, ResourceTemplate ()
            : 		{
            : 			IO (Decode16, 0x70, 0x70, 1, 8)
            : 		})
            : 	}
            : 
            : 	Device (TIMR)
            : 	{
            : 		Name (_HID, EISAID ("PNP0100"))
            : 		Name (_DDN, "8254 Timer")
            : 		Name (_CRS, ResourceTemplate ()
            : 		{
            : 			IO (Decode16, 0x40, 0x40, 0x01, 0x04)
            : 			IO (Decode16, 0x50, 0x50, 0x10, 0x04)
            : 			IRQNoFlags () {0}
            : 		})
            : 	}
> This seems very unspecific to this SOC. […]

CL to move into common 
https://review.coreboot.org/c/coreboot/+/36455