Attention is currently required from: Shelley Chen, Ravi kumar, Ravi Kumar Bokka. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID. ......................................................................
Patch Set 36:
(12 comments)
File src/mainboard/google/herobrine/boardid.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/ca437099_ed75667b PS36, Line 14: if (CONFIG(BOARD_GOOGLE_HEROBRINE)){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/79dad090_2f146c2f PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/60f9ad8c_809f7788 PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/6aadcf4c_0dbd8328 PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){ else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/15fb82e6_814b52c9 PS36, Line 20: pins[2] = GPIO(50); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/5b37bdec_7d664b62 PS36, Line 20: pins[2] = GPIO(50); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/681787a5_18b045be PS36, Line 21: pins[1] = GPIO(49); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/77256db5_9c2fa2eb PS36, Line 21: pins[1] = GPIO(49); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/139c4419_726add6c PS36, Line 22: pins[0] = GPIO(48); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/e1a8cb5e_09ee0b60 PS36, Line 22: pins[0] = GPIO(48); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/d8231d2d_f1cb0485 PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){ space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136026): https://review.coreboot.org/c/coreboot/+/56642/comment/bc36fa0e_1fb88850 PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){ braces {} are not necessary for single statement blocks