Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34685 )
Change subject: drivers/fsp1_1/raminit: fix use of mrc_hob ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34685/3/src/drivers/intel/fsp1_1/ra... File src/drivers/intel/fsp1_1/raminit.c:
https://review.coreboot.org/c/coreboot/+/34685/3/src/drivers/intel/fsp1_1/ra... PS3, Line 262: if (mrc_hob == NULL) Shouldn't the check for CONFIG(DISPLAY_HOBS) be added within if statement? if (mrc_hob == NULL) if (CONFIG(DISPLAY_HOBSS) printk( ..... ) else if