Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39343 )
Change subject: vboot: remove extraneous vboot_recovery_mode_memory_retrain ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/39343/5/src/soc/mediatek/mt8183/mem... PS5, Line 179: vboot_check_recovery_request() == VB2_RECOVERY_TRAIN_AND_REBOOT) {
why do we only handle this recovery reason in MT8183? Shouldn't this also work on Intel?
I had actually not seen this code closely until now. The original intent of VB2_RECOVERY_TRAIN_AND_REBOOT was to simply ensure that the recovery MRC cache has valid training data. On MT8183, it looks like it is being used as a trigger to wipe out the memory training data and force a retrain for recovery mode. That is the reason you don't see any special handling for Intel platforms for recovery mode.