Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42859 )
Change subject: amdfwtool: Take a config file instead of command line parameters ......................................................................
Patch Set 19:
(4 comments)
only had a brief look right now
https://review.coreboot.org/c/coreboot/+/42859/19/3rdparty/amd_blobs File 3rdparty/amd_blobs:
PS19: i'd just put the configuration files into the corresponding soc directories
https://review.coreboot.org/c/coreboot/+/42859/19/Makefile.inc File Makefile.inc:
PS19: are these changes needed?
https://review.coreboot.org/c/coreboot/+/42859/19/src/mainboard/amd/mandolin... File src/mainboard/amd/mandolin/Kconfig:
PS19: unrelated and Mandolin uses ESPI for the EC; there's no EC driver though
https://review.coreboot.org/c/coreboot/+/42859/19/src/soc/amd/picasso/Kconfi... File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/42859/19/src/soc/amd/picasso/Kconfi... PS19, Line 428: #config AMD_PUBKEY_FILE : # string : # default "3rdparty/amd_blobs/picasso/PSP/AmdPubKeyRV.bin" please don't just comment out things; remove instead